I2c slave implementation #452
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATMega328p the correct start state for I2C slave is 0x60 Have a look at capt. 21.7.3 The old version sets the state two times. First state 0x60 and then 0x80 Because the TWI_COND_SLAVE is set before the write and after this true
gatk555
pushed a commit
to gatk555/simavr
that referenced
this pull request
May 25, 2022
…to fix include paths in parts/i2c_master.[ch], initialisation of firmware struct in i2ctest.c (needed after PR buserror#440) and spelling/syntax in README.
|
This needed some small changes when merging: the include paths in parts/i2c_master.[ch] point to an installed version (that I do not have) rather than the build tree and after PR #440 was merged, the firmware struct in i2ctest.c must be initialised. I also tidied some spelling and syntax in the README. My version is here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have implemented a small example for a twi slave on an AVR device.
While I implemented this, I have seen that there a some small bugs within the implementation of the sim_twi.
I think the first was, that the interrupt Flag is cleared while writing a 1 TWIINT register.
The second was some invalid states of the TWI.
I think I have corrected these and attach a very simple implementation of the avr twi slave.
Best regards and many thanks for that great simulator!
seplog