Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mobiledoc 0.3.2 #170

Merged
merged 5 commits into from
Jun 6, 2020

Conversation

lukemelia
Copy link
Collaborator

@lukemelia lukemelia commented Aug 21, 2019

@lukemelia lukemelia force-pushed the chore/update-mobiledoc branch from 801c346 to 678bd8c Compare August 21, 2019 07:02
let editor = this.get('editor');
let attributeName = this.get('attributeName');
let attributeValue = this.get('attributeValue');
editor.setAttribute(attributeName, attributeValue);
Copy link
Contributor

@ZeeJab ZeeJab May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the ability to removeAttribute in mobiledoc-kit so we can make sure to remove the attribute if the attribute is set to the default value (left). Can we incorporate that here so we don't have attributes added to things in the data when the desire is to simply go back to the browser default of left? It makes for a cleaner experience imo.

I did the same thing in the react editor: joshfrench/react-mobiledoc-editor@d7f93b3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZeeJab Makes sense. I'll refine accordingly.

Copy link
Collaborator Author

@lukemelia lukemelia Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. I took a little different approach than in the react version. I think it is better for the editor to determine the default attribute value rather than the toolbar props.

@lukemelia lukemelia force-pushed the chore/update-mobiledoc branch from 678bd8c to 98bbe43 Compare June 4, 2020 07:12
lukemelia added 2 commits June 5, 2020 15:50
Updates to mobiledoc-kit 0.12.4
Adds mobiledoc-section-attribute-button for building toolbars.
Adds text-alignment buttons to mobiledoc-toolbar
Updates README accordingly
@lukemelia lukemelia force-pushed the chore/update-mobiledoc branch from 4c4eed7 to 93653e2 Compare June 5, 2020 07:50
@lukemelia lukemelia merged commit cd15614 into bustle:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants