-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mobiledoc 0.3.2 #170
Conversation
lukemelia
commented
Aug 21, 2019
•
edited
Loading
edited
- Update this PR to point to released mobiledoc-kit once Fix #694: Alignment of a section is removed when pressing "Enter" mobiledoc-kit#695 Add Editor#activeSectionAttributes to support toolbar state… mobiledoc-kit#697 are merged and released
801c346
to
678bd8c
Compare
let editor = this.get('editor'); | ||
let attributeName = this.get('attributeName'); | ||
let attributeValue = this.get('attributeValue'); | ||
editor.setAttribute(attributeName, attributeValue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the ability to removeAttribute
in mobiledoc-kit so we can make sure to remove the attribute if the attribute is set to the default value (left
). Can we incorporate that here so we don't have attributes added to things in the data when the desire is to simply go back to the browser default of left
? It makes for a cleaner experience imo.
I did the same thing in the react editor: joshfrench/react-mobiledoc-editor@d7f93b3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZeeJab Makes sense. I'll refine accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. I took a little different approach than in the react version. I think it is better for the editor to determine the default attribute value rather than the toolbar props.
678bd8c
to
98bbe43
Compare
Updates to mobiledoc-kit 0.12.4 Adds mobiledoc-section-attribute-button for building toolbars. Adds text-alignment buttons to mobiledoc-toolbar Updates README accordingly
4c4eed7
to
93653e2
Compare