Skip to content

Commit

Permalink
chore(ci): Fix CI: Sauce Connect, ChromeHeadless, and MS Edge (#604)
Browse files Browse the repository at this point in the history
Adding quotes to the travis sauce connect addon username and access key
fixes issue connecting to Sauce Labs

Adding sudo chown/chmod calls fixes issue starting headless chrome,
see travis-ci/travis-ci#9024

Forcing using MS Edge version 15 fixes 10 test failures that occur when
testing with MS Edge v16 (see #603)

Fixes #595
  • Loading branch information
bantic authored Feb 23, 2018
1 parent 8ae4d6b commit 5cc0112
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 7 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ dist: trusty
addons:
chrome: stable
sauce_connect:
username: mobiledoc-kit
access_key: f9cad21d-1141-452d-8f64-c6ba3f43faa6
username: "mobiledoc-kit"
access_key: "f9cad21d-1141-452d-8f64-c6ba3f43faa6"

cache:
yarn: true
Expand All @@ -19,5 +19,10 @@ before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 0.27.5
- export PATH=$HOME/.yarn/bin:$PATH

# Fixes issue starting ChromeHeadless, see https://github.com/travis-ci/travis-ci/issues/9024
before_script:
- "sudo chown root /opt/google/chrome/chrome-sandbox"
- "sudo chmod 4755 /opt/google/chrome/chrome-sandbox"

script:
- yarn test:ci
2 changes: 1 addition & 1 deletion testem-ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"launchers": {
"SL_MS_Edge": {
"exe": "saucie",
"args": ["-b", "microsoftedge", "--no-connect", "-u"],
"args": ["-b", "microsoftedge", "-v", "15", "--no-connect", "-u"],
"protocol": "tap"
},
"SL_IE_11": {
Expand Down

0 comments on commit 5cc0112

Please sign in to comment.