Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List items can be enabled, removed based on selections #186

Closed
mixonic opened this issue Oct 23, 2015 · 1 comment · Fixed by #248
Closed

List items can be enabled, removed based on selections #186

mixonic opened this issue Oct 23, 2015 · 1 comment · Fixed by #248
Assignees
@bantic
Milestone
0.8

Comments

@mixonic
Copy link
Contributor

mixonic commented Oct 23, 2015

Any list items currently under select should be toggleable.

A list item under cursor should remove list formatting when toggled

Content-Kit:

Google Docs:

Several selected sections should get list formatting when toggled, unless they already have it

Content-Kit:

Google Docs:
@mixonic mixonic modified the milestone: 0.7 Nov 16, 2015
@bantic bantic self-assigned this Nov 24, 2015
@bantic
Copy link
Collaborator

bantic commented Nov 30, 2015

wip on https://github.com/bustlelabs/mobiledoc-kit/tree/toggle-list-sections-186

@bantic bantic mentioned this issue Dec 1, 2015
Merged
bantic added a commit that referenced this issue Dec 3, 2015
@bantic
Add postEditor#toggleSection, works with ul/ol sections
6a25f7d 
  * deprecated `changeSectionTagName` in favor of `toggleSection` --
    should it be named `toggleSections`?
  * join contiguous list sections -- when a section adjacent to a
    list section is removed, the postEditor will scan for and join
    contiguous list sections in the before_complete queue
  * put cursor position at start of changed range -- the end of the
    range is not stable (it can move around when joinin contiguous lists
    or when the toggle changes the last section to/from a list item) so
    it is quite difficult to select the entire range after the toggle.
  * remove unused `splitAtListItem`, `splitIntoSections` methods on
    ListSection, ListItem
  * add `MarkupSection.isMarkupSection` property
  * add Section `canJoin`, `join` methods
  * add test to ensure toggling while on a card section is a no-op

fixes #186
bantic added a commit that referenced this issue Dec 3, 2015
@bantic
Add postEditor#toggleSection, works with ul/ol sections
d595937 
  * marked `changeSectionTagName` private in favor of `toggleSection`.
    'ember-mobiledoc-editor' uses `changeSectionTagName` so it will need
    to be updated
  * join contiguous list sections -- when a section adjacent to a
    list section is removed, the postEditor will scan for and join
    contiguous list sections in the before_complete queue
  * put cursor position at start of changed range -- the end of the
    range is not stable (it can move around when joinin contiguous lists
    or when the toggle changes the last section to/from a list item) so
    it is quite difficult to select the entire range after the toggle.
  * remove unused `splitAtListItem`, `splitIntoSections` methods on
    ListSection, ListItem
  * add `MarkupSection.isMarkupSection` property
  * add Section `canJoin`, `join` methods
  * add test to ensure toggling while on a card section is a no-op

fixes #186
bantic added a commit that referenced this issue Dec 3, 2015
@bantic
Add postEditor#toggleSection, works with ul/ol sections
c97a160 
  * marked `changeSectionTagName` private in favor of `toggleSection`.
    'ember-mobiledoc-editor' uses `changeSectionTagName` so it will need
    to be updated
  * join contiguous list sections -- when a section adjacent to a
    list section is removed, the postEditor will scan for and join
    contiguous list sections in the before_complete queue
  * put cursor position at start of changed range -- the end of the
    range is not stable (it can move around when joinin contiguous lists
    or when the toggle changes the last section to/from a list item) so
    it is quite difficult to select the entire range after the toggle.
  * remove unused `splitAtListItem`, `splitIntoSections` methods on
    ListSection, ListItem
  * add `MarkupSection.isMarkupSection` property
  * add Section `canJoin`, `join` methods
  * add test to ensure toggling while on a card section is a no-op

fixes #186
bantic added a commit that referenced this issue Dec 7, 2015
@bantic
Add postEditor#toggleSection, works with ul/ol sections
6ddf333 
  * marked `changeSectionTagName` private in favor of `toggleSection`.
    'ember-mobiledoc-editor' uses `changeSectionTagName` so it will need
    to be updated
  * join contiguous list sections -- when a section adjacent to a
    list section is removed, the postEditor will scan for and join
    contiguous list sections in the before_complete queue
  * put cursor position at start of changed range -- the end of the
    range is not stable (it can move around when joinin contiguous lists
    or when the toggle changes the last section to/from a list item) so
    it is quite difficult to select the entire range after the toggle.
  * remove unused `splitAtListItem`, `splitIntoSections` methods on
    ListSection, ListItem
  * add `MarkupSection.isMarkupSection` property
  * add Section `canJoin`, `join` methods
  * add test to ensure toggling while on a card section is a no-op

fixes #186
bantic added a commit that referenced this issue Dec 7, 2015
@bantic
Add postEditor#toggleSection, works with ul/ol sections
77c508c 
  * marked `changeSectionTagName` private in favor of `toggleSection`.
    'ember-mobiledoc-editor' uses `changeSectionTagName` so it will need
    to be updated
  * join contiguous list sections -- when a section adjacent to a
    list section is removed, the postEditor will scan for and join
    contiguous list sections in the before_complete queue
  * put cursor position at start of changed range -- the end of the
    range is not stable (it can move around when joinin contiguous lists
    or when the toggle changes the last section to/from a list item) so
    it is quite difficult to select the entire range after the toggle.
  * remove unused `splitAtListItem`, `splitIntoSections` methods on
    ListSection, ListItem
  * add `MarkupSection.isMarkupSection` property
  * add Section `canJoin`, `join` methods
  * add test to ensure toggling while on a card section is a no-op

fixes #186
bantic added a commit that referenced this issue Dec 8, 2015
@bantic
Add postEditor#toggleSection, works with ul/ol sections
1e47433 
  * marked `changeSectionTagName` private in favor of `toggleSection`.
    'ember-mobiledoc-editor' uses `changeSectionTagName` so it will need
    to be updated
  * join contiguous list sections -- when a section adjacent to a
    list section is removed, the postEditor will scan for and join
    contiguous list sections in the before_complete queue
  * put cursor position at start of changed range -- the end of the
    range is not stable (it can move around when joinin contiguous lists
    or when the toggle changes the last section to/from a list item) so
    it is quite difficult to select the entire range after the toggle.
  * remove unused `splitAtListItem`, `splitIntoSections` methods on
    ListSection, ListItem
  * add `MarkupSection.isMarkupSection` property
  * add Section `canJoin`, `join` methods
  * add test to ensure toggling while on a card section is a no-op
  * Add editor#selectRange, postEditor#setRange APIs
  * Remove Cursor `moveToSection`, `selectSections`, `moveToPosition`
  * use `Cursor#selectRange` primarily, instead (called by `editor#selectRange`)
  * Add Range.fromSection convenience method
  * Remove `Editor#moveToPosition` (in favor of `selectRange`)

fixes #186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bantic bantic

Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging a pull request may close this issue.

Toggle list type sections bustle/mobiledoc-kit
2 participants
@bantic @mixonic