-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editor-dom renderer for card rendering #236
Comments
bantic
added a commit
that referenced
this issue
Nov 18, 2015
1 task
bantic
added a commit
that referenced
this issue
Nov 19, 2015
This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 This allows rendering, but the cards themselves don't render yet because ember-mobiledoc-editor doesn't use the updates to mobiledoc-kit from #238 wip refs #236
1 task
bantic
added a commit
that referenced
this issue
Nov 23, 2015
Update cards to be in format expected by dom renderer This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 Reorganize cards into dom/ html/ and text/ directories fixes #236 fixes #239
bantic
added a commit
that referenced
this issue
Nov 23, 2015
Update cards to be in format expected by dom renderer This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 Reorganize cards into dom/ html/ and text/ directories fixes #236 fixes #239
bantic
added a commit
that referenced
this issue
Nov 23, 2015
Update cards to be in format expected by dom renderer This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 Reorganize cards into dom/ html/ and text/ directories fixes #236 fixes #239
bantic
added a commit
that referenced
this issue
Nov 23, 2015
Update cards to be in format expected by dom renderer This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 Reorganize demo cards into dom/ html/ and text/ directories fixes #236 fixes #239
bantic
added a commit
that referenced
this issue
Nov 23, 2015
Update cards to be in format expected by dom renderer This is based on the changes to mobiledoc-dom-renderer in bustle/mobiledoc-dom-renderer#18 Reorganize demo cards into dom/ html/ and text/ directories fixes #236 fixes #239 Update html and text renderer dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see #235
type
,name
,render
and optionaledit
propertiestype
is validated by renderer (dom renderer cannot render 'text', e.g.)render
(oredit
) methodenv
,options
andpayload
propertiesrender
(oredit
) method is appended/concatenated by rendereronTeardown(teardownFn)
Renderer(not applicable since the editor-dom renderer is managed internally by mobiledoc-kit)constructor
signature changes to accept options object with: cards, atoms, cardOptions, unknownCardHandler, editor (for editor-dom)Rendererrender
instance method acceptsmobiledoc
argument, returnsrendered
object with 2 props:result
property (which is a dom node or string, depending)teardown
method with no args tears down rendered mobiledoc (removing dom when applicable, calling registered card teardown callbacks when applicable)unknownCardHandler
method is called whenever a renderer encounters an unknown cardeditor.destroy()
calls all card teardown callbacksThe text was updated successfully, but these errors were encountered: