Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder is ignored, editor renders __BLANK__ when initialised with no mobiledoc #35

Closed
ErisDS opened this issue Aug 5, 2015 · 1 comment
Closed

Placeholder is ignored, editor renders __BLANK__ when initialised with no mobiledoc #35

ErisDS opened this issue Aug 5, 2015 · 1 comment

Comments

@ErisDS
Copy link
Contributor

ErisDS commented Aug 5, 2015

Initialising a new editor with no Mobiledoc option results in the editor showing __BLANK__:

How I reproduced:

  • on master (58ffbc8) using broccoli serve to test the demo
  • remove line 264 from demo/demo.js (or replace with something like placeholder: 'my custom placeholder')
  • visit http://localhost:4200/demo/ and note the __BLANK__ marker shown in the editor rather than a placeholder.

This was introduced in 0.2.2, in 0.2.1 the placeholder appears.
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
0c0dba8 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined
 * Add empty mobiledoc to demo

fixes #125 #35 #71
@bantic bantic mentioned this issue Sep 14, 2015
Merged
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
d60c0dc 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined
 * Add empty mobiledoc to demo

fixes #125 #35 #71
bantic added a commit that referenced this issue Sep 14, 2015
@bantic
Handle blank mobiledoc in editor
dca9722 
 * Rename Section methods semantically
 * add "simple-card" demo, with "remove" button
 * Clean up cursor detection and embedIntent
 * Add Position.emptyPosition and Range.emptyRange
 * allow mobiledoc to have 0 sections
 * add Post#isBlank
 * Add tests for typing in blank mobiledoc
 * Tests for removing the last item (e.g., card) in a mobiledoc
 * Ensure that replaceSection works when section is undefined
 * Add empty mobiledoc to demo

fixes #125 #35 #71
@bantic
Copy link
Collaborator

bantic commented Sep 14, 2015

Thanks for reporting this! #127 Changed the way an empty mobiledoc is handled, and placeholders now show up appropriately. The demo has an "Empty mobiledoc" option in the dropdown, showing the placeholder in action.

@bantic bantic closed this as completed Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bantic @ErisDS