Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marker.hasMarkup does not detect markup properly for bold/italic buttons #80

Closed
bantic opened this issue Aug 17, 2015 · 0 comments · Fixed by #99
Closed

marker.hasMarkup does not detect markup properly for bold/italic buttons #80

bantic opened this issue Aug 17, 2015 · 0 comments · Fixed by #99
Assignees

Comments

@bantic
Copy link
Collaborator

bantic commented Aug 17, 2015

As of 6d4983d:

  • select text, click "B"
  • type additional text inside the bold text
  • select the bolded text and notice that "B" is not active (blue). It should be active.

This is because when text is input the post parser reparses that section and we end up re-creating the marker w/ the bold markup in the post parser's markupFromNode method. This skips the builder's marker cache because of two bugs there:

  • attributes is present but empty ([]) — this line should check whether it is empty, not just absent
  • newly-created markers without attributes are (mistakenly) not getting cached
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant