Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure using arrow keys when text is selected moves cursor correctly #347

Merged
merged 1 commit into from
Mar 22, 2016

Conversation

bantic
Copy link
Collaborator

@bantic bantic commented Mar 22, 2016

Fixes an issue where selecting text and then hitting left/right would
move the cursor one character past the left/right side of the selection
instead of putting the cursor at the left/right side of the selection.

  • Remove Range#moveFocusedPosition
  • Add Range#move and Range#extend, add tests for same
  • Refactor EventManager's keydown method to use Range #move and #extend

Fixes an issue where selecting text and then hitting left/right would
move the cursor one character past the left/right side of the selection
instead of putting the cursor *at* the left/right side of the selection.

  * Remove `Range#moveFocusedPosition`
  * Add `Range#move` and `Range#extend`, add tests for same
  * Refactor EventManager's `keydown` method to use `Range` `#move` and `#extend`
@bantic bantic force-pushed the fix-selection-arrow-movement branch from 30dfef1 to 58dec72 Compare March 22, 2016 19:37
bantic added a commit that referenced this pull request Mar 22, 2016
Ensure using arrow keys when text is selected moves cursor correctly
@bantic bantic merged commit 17be126 into master Mar 22, 2016
@bantic bantic deleted the fix-selection-arrow-movement branch March 22, 2016 19:47
@bantic
Copy link
Collaborator Author

bantic commented Mar 22, 2016

released in v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant