Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sso-auth: remove deprecated payloads package and alternate code path for loading session #41

Closed
shrayolacrayon opened this issue Aug 28, 2018 · 0 comments
Closed

sso-auth: remove deprecated payloads package and alternate code path for loading session #41

shrayolacrayon opened this issue Aug 28, 2018 · 0 comments
Labels
good first issue Good for newcomers papercuts frustrations to fix but not necessarily a bug

Comments

@shrayolacrayon
Copy link

Why
We have two code paths for loading the session state in sso-auth that we kept in until the cookie refresh period expired for sso in production. We can now remove that code as well as all of the payloads package, and only use the miscreant implementation of AES-SIV for encrypting and decrypting session state.

This would involve removing:
@shrayolacrayon shrayolacrayon added good first issue Good for newcomers papercuts frustrations to fix but not necessarily a bug labels Aug 28, 2018
@jphines jphines mentioned this issue Sep 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers papercuts frustrations to fix but not necessarily a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shrayolacrayon