sso: remove old cipher fallback #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready For Review @shrayolacrayon |
|
This looks great! ✂️ |
jphines
force-pushed
the
remove-old-cipher-fallback
branch
from
f4dc8fe
to
8e427e2
Compare
|
@shrayolacrayon removed those pkgs |
shrayolacrayon
previously approved these changes
Sep 18, 2018
|
lgtm! |
jphines
force-pushed
the
remove-old-cipher-fallback
branch
2 times, most recently
from
42644c2
to
cbdbe4e
Compare
jphines
force-pushed
the
remove-old-cipher-fallback
branch
from
cbdbe4e
to
5d75d96
Compare
shrayolacrayon
approved these changes
Sep 18, 2018
|
Did this fix #29? Can that be closed now? |
|
edi: nope, nevermind. i was basing that opinion on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a legacy fallback cipher that was used when we migrated session encryption schemas. This legacy fallback is no longer used and adds needless complexity.
Solution
We should remove the legacy fallback cipher.
Notes
This removes the legacy fallback cipher in both sso proxy and authenticator.
Fixes #41
Fixes #42