sso-proxy: internal host should apply to redeem, /refresh, /validate, /profile

[benjsto]

Problem

Dan's PR added the ability to have an optional 'internal' host defined that proxy will use to connect to auth. However, that internal host was only applied on /redeem requests. Other cases where proxy makes a request to auth, like /refresh, /validate, or /profile should also use this internal host if it is provided.

Solution

If the optional PROVIDER_URL_INTERNAL is set, use that host to connect to auth for /redeem, /refresh, /validate, and /profile.

[danbf]

I'd rather not make a breaking change here in the env-var name if possible even if we do it internally to make things clearer. if we do change things, let's make sure we update the things like the quickstart:

sso/quickstart/docker-compose.yml

Line 32 in 6db5495

- PROXY_PROVIDER_URL=http://host.docker.internal

[danbf]

should we try to re-jigger the kubernetes quick start here

sso/quickstart/kubernetes/sso-proxy-deployment.yml

Lines 26 to 27 in 6db5495

	- name: PROVIDER_URL
	value: https://sso-auth.mydomain.com

to enable the internal connection between sso-proxy->sso-auth ?

[benjsto]

yep, good idea - added.

[danbf]

@benjsto thanks much for finding these. i like your solution in here neater then the one i pushed earlier.

[benjsto]

Thanks @danbf for catching that the Host header on requests to sso-auth still need to use the non-internal host, as that service specifically looks only for that Host header and will 404 without.

[danbf]

LGTM 👍