Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to image to help with Istio liveness checks #147

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

gordcorp
Copy link
Contributor

Problem

When SSO is deployed with Istio mutual TLS enabled, the normal liveness checks will not work i.e. these:

livenessProbe:
  httpGet:
    path: /ping
    port: 4180
    scheme: HTTP
readinessProbe:
  httpGet:
    path: /ping
    port: 4180
    scheme: HTTP

If mutual TLS is enabled, http and tcp health checks from the kubelet will not work since the kubelet does not have Istio-issued certificates.

Further reading here: https://istio.io/help/faq/security/#k8s-health-checks

Solution

The above link suggests using a liveness command, e.g. by installing curl and using that instead. curl is not currently available in the built image, so this PR adds it.

It would then be possible to use SSO in a cluster with Istio mutual TLS enabled, i.e. the checks can then be changed to

livenessProbe:
  exec:
    command:
      - curl
      - -f
      - http://localhost:4180/ping
readinessProbe:
  exec:
    command:
      - curl
      - -f
      - http://localhost:4180/ping

Copy link
Contributor

@jphines jphines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to include

@jphines jphines merged commit 1595da9 into buzzfeed:master Jan 23, 2019
@gordcorp gordcorp deleted the curl branch January 23, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants