Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy: default allowed groups #148

Merged
merged 1 commit into from
Jan 25, 2019
Merged

proxy: default allowed groups #148

merged 1 commit into from
Jan 25, 2019

Conversation

jphines
Copy link
Contributor

@jphines jphines commented Jan 24, 2019

Problem

We have the need to specify default allowed groups

Solution

Allow us to specify default allowed groups via env config for every upstream.

Notes

Needs some tests.

@loganmeetsworld
Copy link
Contributor

gonna need to add

internal/proxy/options.go:118:16: unknown field 'DefaultGroups' in struct literal of type Options

@jphines jphines force-pushed the default-allowed-groups branch 10 times, most recently from 6ae9d2a to 65caf4c Compare January 24, 2019 22:12
@jphines jphines merged commit 4fed3dc into master Jan 25, 2019
@jphines jphines deleted the default-allowed-groups branch April 1, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrayolacrayon shrayolacrayon shrayolacrayon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jphines @loganmeetsworld @shrayolacrayon