sso-proxy: clear csrf token further down the request flow #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphines
previously approved these changes
Mar 28, 2019
Jusshersmith
force-pushed
the
jusshersmith-group-membership-refresh-error
branch
from
2c8348f
to
9f1fb4e
Compare
jphines
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, upon refresh of the
Group membership requirederror page it changes to ahttp: named cookie not presenterror page. Related issue: #94Solution
We currently remove the CSRF token from the request after getting and assigning it to a new variable. If, further down the flow the request is found to be invalid for some reason (in this case, the user not being in the required groups) then the relevant error page is given. Upon refresh it tries to grab the CSRF token again however it's no longer part of the request, and so it errors in a less helpful and informative way.
Instead, only clear the CSRF token once we know the request has passed the various checks