Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

providers: group caching mechanism for okta provider #184

Merged
merged 2 commits into from
May 10, 2019
Merged

providers: group caching mechanism for okta provider #184

merged 2 commits into from
May 10, 2019

Conversation

Jusshersmith
Copy link
Contributor

@Jusshersmith Jusshersmith commented Apr 30, 2019 •
edited
Loading

Caching mechanism for groups returned by the Okta provider

  • Includes a new module in the groups package: internal/pkg/groups/localcache.go for local caching of groups.
    • Tests included
  • A new 'GroupCache' provider which wraps subsequent provider functions, including checks for cached entries using the above 'localcache' for the provider's ValidateGroupMembership function.
    • Tests included
  • Adds a statsdClient to the provider interface (and adds/modifies the relevant provider function where necessary)
  • New vendored depedency for https://godoc.org/golang.org/x/sync/syncmap

@Jusshersmith Jusshersmith force-pushed the jusshersmith-okta-sso-group-caching branch from a25247f to 154e82b Compare April 30, 2019 15:36
@Jusshersmith Jusshersmith marked this pull request as ready for review April 30, 2019 15:39
@Jusshersmith Jusshersmith changed the title Jusshersmith okta sso group caching [WIP] providers: group caching mechanism for okta provider Apr 30, 2019
jphines
jphines reviewed May 1, 2019
View reviewed changes
internal/auth/options.go Outdated Show resolved Hide resolved
@jphines jphines added the enhancement New feature or request label May 7, 2019
jphines
jphines previously approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@jphines jphines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash and we can get this!

@Jusshersmith
new group cache package and cache provider
2689e6e 
creation of an on-demand group cache package, and a new 'groupcache' provider wrapper with
tests for both.
@Jusshersmith
go mod
02669c1 
adding new sync vendored dir
@Jusshersmith Jusshersmith force-pushed the jusshersmith-okta-sso-group-caching branch from 193dee9 to 02669c1 Compare May 8, 2019 10:20
@Jusshersmith Jusshersmith merged commit f98cee3 into master May 10, 2019
@Jusshersmith Jusshersmith deleted the jusshersmith-okta-sso-group-caching branch May 10, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphines jphines jphines approved these changes

Assignees

@Jusshersmith Jusshersmith

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jusshersmith @jphines