docker: don't run as root #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreiferson
force-pushed
the
docker-non-root-user
branch
from
40fd2c9
to
d339286
Compare
|
Hi @cameronattard, thanks for this! FYI I pushed up a whitespace at EOF fix, waiting for the build to test locally. |
|
(validated this with quickstart) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is best practice to run containers as a non-root user. Currently, the
ssocontainer runs as root.Solution
Create a non-root user,
sso, in the image and configure the container to run as this user using theUSERdirective.