Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_auth: add identity provider slug to url path and mux #195

Merged
merged 2 commits into from
May 29, 2019

Conversation

jphines
Copy link
Contributor

@jphines jphines commented May 10, 2019

Problem

As we move towards supporting multiple providers within sso-auth, we need to provide unique callback urls for each identity provider.

Solution

We add more provider slug prefixes to url paths and supply a default provider to support unique callback urls as well as preserve backward's compatibility

Notes

  • Creates a new AuthenticatorMux struct to house the mux mechanism for multiple Authenticators
  • Move initialization from main.go to NewAuthenticatorMux
  • Make newStatsdClient public to call from initialization from main.go
  • Add new Slug struct field to ProviderData to differentiate between providers.

@jphines jphines added the enhancement New feature or request label May 10, 2019
@jphines jphines self-assigned this May 10, 2019
@jphines jphines changed the title Auth provider url path sso_auth: add identity provider slug to url path and mux May 10, 2019
internal/auth/options.go Outdated Show resolved Hide resolved
@jphines jphines force-pushed the auth-provider-url-path branch 2 times, most recently from 1d2b2f2 to 287e270 Compare May 28, 2019 20:36
@Jusshersmith Jusshersmith self-requested a review May 29, 2019 15:18
Copy link
Contributor

@Jusshersmith Jusshersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - nice work @jphines! 🐙

@jphines jphines merged commit f302bca into master May 29, 2019
@jphines jphines deleted the auth-provider-url-path branch May 29, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants