sso_proxy: don't set timeout when flush interval is set #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphines
previously approved these changes
May 23, 2019
Jusshersmith
force-pushed
the
jusshersmith-fix-request-flushing
branch
from
4ff887a
to
0a6fa1b
Compare
jphines
suggested changes
May 23, 2019
add test for flush interval vs timeout logic
Jusshersmith
force-pushed
the
jusshersmith-fix-request-flushing
branch
from
91e348d
to
d7f1780
Compare
jphines
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
http.TimeoutHandlerdoesn't support request flushing, resulting in any flush interval set being ignored if a timeout is also set (we set a default timeout, but not flush interval, so right now this problem always occurs if a flush interval is set).https://golang.org/src/net/http/server.go?s=98830:98898#L3129
Solution
If a flush interval is set in the upstream config, return the handler without setting a timeout.