Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authenticator: remove misc/cruft configuration #207

Merged
merged 6 commits into from
Jun 4, 2019

Conversation

jphines
Copy link
Contributor

@jphines jphines commented Jun 3, 2019

Problem

There is a ton of non-useful, unusable, or crufty configuration leftover in sso auth. This is an attempt to clean up the cruft configs.

@jphines jphines added the chore Maintenance, cleanup, and administrative label Jun 3, 2019
@jphines jphines requested a review from Jusshersmith June 3, 2019 21:18
@jphines jphines self-assigned this Jun 3, 2019
@jphines jphines force-pushed the remove-misc-configuration branch from 7e0161a to 81eda2e Compare June 4, 2019 02:57
@Jusshersmith Jusshersmith self-requested a review June 4, 2019 16:20
Copy link
Contributor

@Jusshersmith Jusshersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@benjsto benjsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Love the cleanup.

@jphines jphines merged commit 05eef8d into master Jun 4, 2019
@jphines jphines deleted the remove-misc-configuration branch June 4, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance, cleanup, and administrative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants