Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove minimum coverage setting #214

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

Jusshersmith
Copy link
Contributor

Problem

With the recent introduction of codecov, builds are failing to pass checks if their coverage falls below that of master.

Solution

  • Although we want to increase coverage, I'm not sure if we want to set those hard limitations immediately?

    If I understand correctly these changes should remove the 'target', so we'll still get the PR comment but it won't fail due to coverage levels.

  • This also adds the codecov badge to our readme.

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #214 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   61.23%   61.21%   -0.02%     
==========================================
  Files          50       50              
  Lines        4073     4071       -2     
==========================================
- Hits         2494     2492       -2     
  Misses       1393     1393              
  Partials      186      186
Impacted Files Coverage Δ
internal/auth/providers/okta.go 61.57% <0%> (-0.32%) ⬇️

@Jusshersmith
Copy link
Contributor Author

Would we prefer to set a threshold perhaps? (allow the PR to drop by x% (5%?), but still pass)

@jphines
Copy link
Contributor

jphines commented Jun 17, 2019

@Jusshersmith the threshold SGTM, maybe 2-3%?

@Jusshersmith Jusshersmith force-pushed the jusshermsith-modify-codecov-settings branch from 5ea2354 to da6ba79 Compare June 17, 2019 22:06
jphines
jphines previously approved these changes Jun 24, 2019
@Jusshersmith Jusshersmith force-pushed the jusshermsith-modify-codecov-settings branch from 43a95d4 to 2dae354 Compare June 25, 2019 09:50
@Jusshersmith
Copy link
Contributor Author

🙏 @jphines, please review/re-approve when you have the chance. Updated comments slightly to give some information around validating config.

@Jusshersmith Jusshersmith merged commit fc431c6 into master Jun 25, 2019
@Jusshersmith Jusshersmith deleted the jusshermsith-modify-codecov-settings branch June 25, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants