-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: amazon cognito provider #250
Conversation
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 62.53% 61.35% -1.18%
==========================================
Files 54 57 +3
Lines 4201 4637 +436
==========================================
+ Hits 2627 2845 +218
- Misses 1385 1580 +195
- Partials 189 212 +23
|
fab3bbb
to
b2442dd
Compare
c6a21f2
to
d97ca19
Compare
👋 @jphines - pinging you on this as although you wrote the first portion, a fair chunk (and time) has been added since then, so seems worth another general look over, providing you have the bandwidth? I think the biggest things that have been added/changed is the group membership validation logic (https://github.com/buzzfeed/sso/pull/250/files?file-filters%5B%5D=.go#diff-ea62f132a9d50a2ecbeb99d1dd8c48e1R340), |
A few comment nits -- but the logic looks good. |
0356d01
to
25ae7f2
Compare
amazon-cognito: init amazon-cognito: setup ok tests wip sign out aws sdk initial commit for group verification feature some extra tests empty string slice, not string additional cognito provider test extra provider tests add new tests, and move to options_test.go file fix cognito validategroup tests create separate mock admin files minor edits remove some comments couple small improvements amazon mock admin changes following review remove unnecessary method fixed tests following on from review changes some updates from review fix struct name in tests
25ae7f2
to
4ff8836
Compare
This adds an additional Identity Provider for Amazon Cognito.
There are some TODO's here: