Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_proxy: add test for websockets and update docs #256

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

Jusshersmith
Copy link
Contributor

Problem

We've recently introduced support for websockets, however we didn't include any tests or documentation updates in the initial pull request.

Solution

Add in a couple of simple tests and documentation updates. Also, the docker golang image that CircleCI uses has been updated to 1.12 to bring it in line with SSO's go version (required for websocket support)

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   62.04%   62.04%           
=======================================
  Files          50       50           
  Lines        4105     4105           
=======================================
  Hits         2547     2547           
  Misses       1370     1370           
  Partials      188      188

@Jusshersmith Jusshersmith self-assigned this Oct 8, 2019
Copy link
Contributor

@benjsto benjsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test - this will be great to have if/when we do decide to move the hijack to a different handler.

@Jusshersmith Jusshersmith merged commit f426749 into master Oct 10, 2019
@Jusshersmith Jusshersmith deleted the jusshersmith-test-websockets branch October 10, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants