Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_*: allow group validator to be used standalone #264

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

Jusshersmith
Copy link
Contributor

Problem

We require either allowed_email_addresses or allowed_email_domains to be passed in either as a default or for each upstream, however this limits the usability of email groups as a functional validator. It's difficult to validate a user based on groups alone if you also have to specify email addresses or email domains, for example -- it requires work arounds which should be avoided.

Solution

Require allowed_email_addresses, allowed_email_domains OR allowed_groups instead. This means the email group validator can still be used simultaneously with others, but also standalone which allows for a sometimes more expected workflow.

Notes

This PR also removes functionality that means if an empty list of groups is passed in to the validator then the user is automatically 'valid' per the group validator. If a group validator can be the only validator, I don't think this logic makes sense (however there may be other historic reasons why this was allowed that I'm unaware of)

@Jusshersmith Jusshersmith added the bug Something isn't working label Oct 30, 2019
@Jusshersmith Jusshersmith self-assigned this Oct 30, 2019
@Jusshersmith Jusshersmith merged commit b76969f into master Oct 30, 2019
@Jusshersmith Jusshersmith deleted the jusshersmith-fix-proxy-validator-options branch October 30, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants