sso_proxy: allow empty slice of groups #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 61.85% 61.87% +0.01%
==========================================
Files 57 57
Lines 4638 4640 +2
==========================================
+ Hits 2869 2871 +2
Misses 1556 1556
Partials 213 213
Continue to review full report at Codecov.
|
jphines
previously approved these changes
Mar 16, 2020
Jusshersmith
force-pushed
the
jusshersmith-temp-group-validation-fix
branch
from
4465b1e
to
565ab66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #286
Solution
This implements the initial fix described in #286. I think there may be a couple extra edge cases we need to cover in that pull request, so I've pulled out the fix here so it can be applied separately.