Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sso_proxy: document provider slug configs #301

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

Jusshersmith
Copy link
Contributor

Problem

Some documentation for the upstream configuration option provider_slug, and the global sso_proxy
DefaultProviderSlug option is missing

Solution

Add in the missing documentation.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #301 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   61.98%   61.84%   -0.15%     
==========================================
  Files          57       57              
  Lines        4646     4188     -458     
==========================================
- Hits         2880     2590     -290     
+ Misses       1554     1388     -166     
+ Partials      212      210       -2     
Impacted Files Coverage Δ
internal/proxy/options.go 83.59% <ø> (-1.08%) ⬇️
internal/auth/http.go 60.00% <0.00%> (-6.67%) ⬇️
internal/auth/providers/internal_util.go 55.55% <0.00%> (-4.45%) ⬇️
internal/auth/static_files.go 69.23% <0.00%> (-4.11%) ⬇️
internal/auth/configuration.go 43.68% <0.00%> (-3.74%) ⬇️
internal/pkg/aead/aead.go 62.96% <0.00%> (-3.71%) ⬇️
internal/auth/circuit/breaker.go 81.98% <0.00%> (-2.40%) ⬇️
internal/pkg/groups/fillcache.go 72.30% <0.00%> (-2.35%) ⬇️
internal/proxy/proxy_config.go 76.21% <0.00%> (-2.28%) ⬇️
internal/auth/middleware.go 80.43% <0.00%> (-2.26%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc9145...d2e1ee5. Read the comment docs.

@Jusshersmith Jusshersmith force-pushed the jusshersmith-update-proxy-config-docs branch from b965d1b to d2e1ee5 Compare October 19, 2020 13:15
@jphines
Copy link
Contributor

jphines commented Oct 20, 2020

This is annoying. Do we want to force merge?

@Jusshersmith
Copy link
Contributor Author

@jphines Actually, I think that might be a good idea. I've tried to dig into why it's suggesting this change in code coverage, but unclear at the moment.

If you're happy with the change, let's force merge 👍

@jphines jphines merged commit a3c8a2a into master Oct 22, 2020
@jphines jphines deleted the jusshersmith-update-proxy-config-docs branch October 22, 2020 14:16
@Jusshersmith Jusshersmith added the docs Documentation label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants