sso-proxy: remove default provider and unused functions #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrayolacrayon
force-pushed
the
proxy-remove-default-provider
branch
from
cbdfeab
to
51ab4e5
Compare
katzdm
previously approved these changes
Oct 18, 2018
internal/proxy/providers/sso.go
Outdated
|
|
||
| // GetSignInURL with typical oauth parameters | ||
| func (p *SSOProvider) GetSignInURL(redirectURL *url.URL, state string) *url.URL { | ||
| var a url.URL |
There was a problem hiding this comment.
nit: Unless I'm missing a reason not to, let's write a := *p.Data().SignInURL() for consistency.
Also in GetSignOutURL() below.
internal/proxy/providers/sso.go
Outdated
| @@ -383,3 +386,43 @@ func (p *SSOProvider) ValidateSessionState(s *SessionState, allowedGroups []stri | |||
|
|
|||
| return true | |||
| } | |||
|
|
|||
| // signRedirectURL signs the redirect url string, given a timestamp, and returns it | |||
| func signRedirectURL(clientSecret, rawRedirect string, timestamp time.Time) string { | |||
There was a problem hiding this comment.
nit: I always double take when reading through code that uses this syntax pattern - Would you mind explicitly spelling the type string alongside clientSecret?
func signRedirectURL(clientSecret string, rawRedirect string, timestamp time.Time) string {
shrayolacrayon
dismissed stale reviews from loganmeetsworld and katzdm
via
6cf0ad0
shrayolacrayon
force-pushed
the
proxy-remove-default-provider
branch
from
51ab4e5
to
6cf0ad0
Compare
shrayolacrayon
force-pushed
the
proxy-remove-default-provider
branch
from
6cf0ad0
to
a0dc38e
Compare
shrayolacrayon
force-pushed
the
proxy-remove-default-provider
branch
from
a0dc38e
to
6eee8aa
Compare
loganmeetsworld
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Some refactoring to make moving sso-proxy to use
Sessions.SessionStoreeasier. This deletes theprovider_defaultin sso-proxy and moves creating the fullSignInURLandSignOutURLinto providers package functions rather than being part of the interface.cc @buzzfeed/sso-maintainers