-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of items aren't loading on demos for IE10 #269
Comments
Right. Unfortunately I think this is because Babel is using (function() {
if (!(Object.setPrototypeOf || {}.__proto__)) {
var nativeGetPrototypeOf = Object.getPrototypeOf;
Object.getPrototypeOf = function(object) {
if (object.__proto__) {
return object.__proto__;
} else {
return nativeGetPrototypeOf.call(Object, object);
}
}
}
})(); I should probably update the demo app to at least monkey patch it. |
Related to babel/babelify/issues/133 and #242 |
Let me think on this a bit. :) |
I think the reason this recently broke was that I added
There are a couple of ways of fixing this. Need to decide which is the best. :) |
I think the path of least pain for react-virtualized users would be for me to convert to composition for these 2 libraries now. Working on that currently. |
Check out version 7.3.3. Should work again for IE10+ Thanks for the detailed bug report, @jasonlee-alation. Sorry it took me a few hours to get around to resolving it. :) |
PS Apparently my most recent deploy of the demo site is causing IE10 some other pain (not yet sure why) but this has to do with the bundling of my demo app itself. The local version of the demo app (with the update to react-virtualized) is IE10-compatible so hopefully this should unblock you. It's late here but I'll take a look at the demo site again tomorrow. |
Demo page has been fixed for IE9 and IE10. :) |
The demo page on ie10 isn't loading its collection of items for all demos except 'Collection'. This is leading to empty grids/tables/virtual scrolls
This was tested on Browserstack windows 8 ie10.
From what I understand react-virtualized does support ie10 judging from the -ms- vendor specific flex attributes
The text was updated successfully, but these errors were encountered: