Avoid crash if WeakSet is not available #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WeakSet
is not available in IE11, so usingreact-window
in development mode causes a runtime error.This simply falls back to
Set
ifWeakSet
is not available. This could have memory implications sinceSet
will hold onto the references indefinitely, but that only affects the one browser and only in development mode. It's also a much smaller impact on bundle size vs., say, a polyfill.