rename overscan props for Gird with deprecation #229
Conversation
src/__tests__/FixedSizeGrid.js
Outdated
| ); | ||
| expect(console.warn).toHaveBeenCalledTimes(1); | ||
| expect(console.warn).toHaveBeenLastCalledWith( | ||
| 'The overscanCount prop has been deprecated. ' + | ||
| 'Please use the overscanColumnsCount and overscanRowsCount props instead.' | ||
| 'The overscanCount, overscanColumnsCount and overscanRowsCount props have been deprecated. ' + |
There was a problem hiding this comment.
I think this message may be a bit confusing for people who were unaware of the old overscanCount prop. Seems like it would be better to split these into two warnings?
|
Hey @bvaughn , I'd like to ask for your help for an off-topic problem, Autodesk/react-base-table#22, do you have any idea to avoid a second rendering to solve the problem, that is if I know it's a pure client rendering I could just use the real scrollbar size in construction, or I have to update it in I also found that in I noticed this problem after I migrated to |
| Please use the <code>overscanRowCount</code> property instead. | ||
| </p> | ||
| ), | ||
| name: 'overscanRowsCount', |
There was a problem hiding this comment.
I think you forgot to rename overscanRowsCount -> overscanRowCount for the pre-existing one. 😁 I'll do it!
|
Released in 1.8.2 - https://github.com/bvaughn/react-window/blob/master/CHANGELOG.md#182 |
close #226