Partially fix VerticalScrollOverflowView #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on https://twitter.com/brian_d_vaughn/status/1422034168612102147!
I've fixed some of the major scrolling issues, but it's still a little incomplete. Making a PR with what I have so far to your branch as it's getting late. I can continue fixing the known issues in a future PR.
Known issues:
_contentView
'sdesiredSize()
isn't returning the new height.This PR also targets your repo and branch since it's based off your stashed code – let me know if I should retarget this upstream :)
Test Plan
Before
Screen.Recording.2021-08-09.at.10.30.41.PM.mov
After
Screen.Recording.2021-08-09.at.10.09.27.PM.mov