This commit accounts for differences in JSONTree's renderer callbacks. #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valueRenderer: passes a scalar value as an argument to the callback you provide.
labelRenderer: passes a array value as an argument to the callback you provide.
This array value is the key ancestry of the json tree.
The Problem:
The name formating issue in FilterableState.js was caused by rendering the
entire key ancestry array as a string for every key, instead of just the name of the key.
Example:
when trying to render the "child" from this piece of state
the
labelRenderer
callback, you provided, will be given the key and its ancestry as a value.JSONTree
takes the return oflabelRenderer
and renders it as astring. So the above return value becomes "childparentgrandParent".
This is why you get the visual bug in the preview of state for the LogMonitor.
The Solution:
return the first key, instead of the entire key ancestry, to get the
correctly formatted label.