Skip to content

Commit

Permalink
[mlir][StorageUniquer] Restore old signature for default implementaio…
Browse files Browse the repository at this point in the history
…n of verifyInvariants. (llvm#103023)

PR llvm#102326 changed the prototype of the default implementation of verify
to include emitErrorFn.

This breaks automatic derivation in consumer attributes, such as
https://github.com/tensorflow/runtime/blob/60277ba976739502e45ad26585e071568fa44af1/include/tfrt/core_runtime/opdefs/attributes.h#L53.

This PR simply restores the signature to what it was prior to PR
llvm#102326.
  • Loading branch information
bchetioui authored and bwendling committed Aug 15, 2024
1 parent 5788a71 commit f56443e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions mlir/include/mlir/IR/StorageUniquerSupport.h
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,7 @@ class StorageUserBase : public BaseT, public Traits<ConcreteT>... {

/// Default implementation that just returns success.
template <typename... Args>
static LogicalResult
verifyInvariants(function_ref<InFlightDiagnostic()> emitErrorFn,
Args... args) {
static LogicalResult verifyInvariants(Args... args) {
return success();
}

Expand Down

0 comments on commit f56443e

Please sign in to comment.