Add Guild Member avatar #1077
Merged
Add Guild Member avatar #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see this is a duplicate of #985, but the original author seems to be inactive after being asked for some changes w.r.t #985 (comment) I saw other |
FedorLap2006
requested changes
Jan 31, 2022
FedorLap2006
approved these changes
Jan 31, 2022
|
Tip: you can resolve conversations when they're outdated or finished. Anyways, thank you for the PR. 👍 |
|
It's ready to be merged, but please note the conflict. |
* add avatar field on Member struct * add endpoints for guild avatars * add avatarURL util function for *User.AvatarURL and *Member.AvatarURL * set GuildID on after GuildMember request
andresperezl
force-pushed
the
guild_member_avatar
branch
from
474ff8b
to
1fb67c8
Compare
|
@FedorLap2006 I have rebased my changes with latest |
FedorLap2006
requested changes
Feb 19, 2022
FedorLap2006
approved these changes
Feb 25, 2022
|
Thanks for the contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965
This PR adds support for the Guild-specific member avatar, if any.
To follow the same pattern as
*User.AvatarURL, also add the same method for*Member.AvatarURL, and create an util methodavatarURLto handle both.Also, set the
*Member.GuildIDafter theGuildMemberrequests, as this is not included with the returned object.I have tested these changes with my own bot