Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auditlog keys and actions #1098

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Update auditlog keys and actions #1098

merged 5 commits into from
Feb 16, 2022

Conversation

phenpessoa
Copy link
Contributor

Added missing audit logs actions and keys, also reordered them to follow the order in the discord docs (https://discord.com/developers/docs/resources/audit-log)

For the audit log change key, in the discord docs the table has 4 columns (name, object changed, type, description).
To follow that, I decided to go with this "syntax":
AuditLogChangeKeyAfkChannelID AuditLogChangeKey = "afk_channel_id" // afk channel changed (snowflake) - guild
// Description (type) - object changed. Let me know what you think of this.

Copy link
Collaborator

@FedorLap2006 FedorLap2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But the convention is to put doc comments on top of the definitions. So, please change that.

@FedorLap2006
Copy link
Collaborator

Thank you for the contribution!

@FedorLap2006 FedorLap2006 merged commit c26bf45 into bwmarrin:master Feb 16, 2022
SmoothieNoIce pushed a commit to SmoothieNoIce/discordgo that referenced this pull request Feb 17, 2022
* update audit log keys and actions

* remove unncessary tab

* move comments above

* feat: corrected comments for audit log change keys

* fix: typos in audit log change keys comments and definitions

Co-authored-by: nitroflap <fe.lap.prog@gmail.com>
@FedorLap2006 FedorLap2006 added this to the v0.24.0 milestone Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants