Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SelectMenu): default values #1452

Merged
merged 3 commits into from
Dec 8, 2023
Merged

feat(SelectMenu): default values #1452

merged 3 commits into from
Dec 8, 2023

Commits on Sep 27, 2023

  1. feat(SelectMenu): default values

    @FedorLap2006
    FedorLap2006 committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    c89341f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. fix: remove unncessary pointer 

    Since SelectMenu is used as a nested structure, it is not possible to
partially edit it. Thus, an empty slice does not need to be accounted for,
and the pointer, which would only be omitted if the value is nil, can be
converted to a regular slice.
    @FedorLap2006
    FedorLap2006 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    13703ce View commit details
    Browse the repository at this point in the history

  2. fix: correct grammar in the comment to SelectMenuDefaultValueType

    @FedorLap2006
    FedorLap2006 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    2f43130 View commit details
    Browse the repository at this point in the history