Added user-agent #653
Merged
Added user-agent #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious, what's the reason for exposing the UserAgent? I thought Discord wanted it to be presented in the specific format we were using. What use case would an end-user of the library need to use a different user agent? |
|
you're supposed to be able to add more metadata to the user agent than just the project URL and version. whether or not this would actually be necessary for anything is up for debate but it should still be something people can do if they want.
|
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.