Support for Batch Request Guild Members #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is supported by the Discord API and will save requests.
|
This is backwards compatibility breaking change. I'd suggest adding a new function. |
|
Updated to eliminate breaking backwards compatibility issue |
JurrijnP
reviewed
Oct 26, 2019
wsapi.go
Outdated
Comment on lines
401
to
406
| type requestGuildMembersData struct { | ||
| GuildID []string `json:"guild_id"` | ||
| Query string `json:"query"` | ||
| Limit int `json:"limit"` | ||
| GuildID string `json:"guild_id"` | ||
| GuildIDs []string `json:"guild_id"` | ||
| Query string `json:"query"` | ||
| Limit int `json:"limit"` | ||
| } |
There was a problem hiding this comment.
You can leave the struct the same as before so:
type requestGuildMembersData struct {
GuildID []string `json:"guild_id"`
Query string `json:"query"`
Limit int `json:"limit"`
}And then pass the argument in the original function to the slice.
…o BatchRequestGuildMembers
…o BatchRequestGuildMembers
…o BatchRequestGuildMembers
CarsonHoffman
requested changes
Dec 27, 2019
CarsonHoffman
approved these changes
Dec 28, 2019
mistahj67
added a commit
to warmind-io/discordgo
that referenced
this pull request
Jan 12, 2020
Support for Batch Request Guild Members
mistahj67
added a commit
to warmind-io/discordgo
that referenced
this pull request
May 10, 2020
Support for Batch Request Guild Members
ErikMcClure
pushed a commit
to ErikMcClure/discordgo
that referenced
this pull request
Aug 4, 2020
Support for Batch Request Guild Members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supported by the Discord API and will save requests.