Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates API #785

Merged
merged 7 commits into from
Jun 28, 2020
Merged

Updates API #785

merged 7 commits into from
Jun 28, 2020

Conversation

TroyKomodo
Copy link
Contributor

Updates the golang stuct to current api documentation and adds new util

TroyKomodo
TroyKomodo commented Jun 24, 2020
View reviewed changes
util.go Outdated Show resolved Hide resolved
@CarsonHoffman
Copy link
Collaborator

Hi! Thank you for submitting this PR; in accordance with the Contributing section of the README, we'd prefer that any PRs are opened against the develop branch rather than master. You should be able to change the target branch in the PR, however please also rebase your minor-updates branch onto our develop branch before doing so, or else any differences between master and develop will also be brought into this PR.

@TroyKomodo
Copy link
Contributor Author

Oh sorry my bad.

@TroyKomodo TroyKomodo changed the base branch from master to develop June 24, 2020 17:20
@TroyKomodo
Copy link
Contributor Author

Did i mess it up?

@CarsonHoffman
Copy link
Collaborator

It looks like you didn't rebase your branch onto develop; notice that a commit that I had submitted to master is now part of the PR.

@TroyKomodo
Copy link
Contributor Author

Yeah i saw sorry, ill rebase.

@TroyKomodo
Copy link
Contributor Author

I think we coo now?

@TroyKomodo
Copy link
Contributor Author

Sorry im not clued up with git commands idk if there is a better way.

@TroyKomodo
Copy link
Contributor Author

I am not sure if this is all the minor api changes, its the ones that i have used in my bot.

CarsonHoffman
CarsonHoffman requested changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@CarsonHoffman CarsonHoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, but they'll make the library's Godoc more consistent!

message.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
structs.go Outdated Show resolved Hide resolved
@TroyKomodo
Copy link
Contributor Author

👍 i looked at integrations too. Thought might aswell go through the other stuff and make sure the discordgo was consistent with the current api.

@TroyKomodo
Copy link
Contributor Author

yeah have fun going through it <3

@TroyKomodo
Copy link
Contributor Author

Does it fix #386 ?

CarsonHoffman
CarsonHoffman requested changes Jun 26, 2020
View reviewed changes
message.go Outdated Show resolved Hide resolved
@CarsonHoffman
Copy link
Collaborator

I went ahead and rebased the changes onto the develop branch for you; your attempt at reverting a commit as a rebase unfortunately left your branch in a state that was unable to be merged. Anyway, thanks for all the extra functionality that this PR brings to the library!

@CarsonHoffman CarsonHoffman reopened this Jun 28, 2020
@CarsonHoffman CarsonHoffman merged commit 9ce4a23 into bwmarrin:develop Jun 28, 2020
@TroyKomodo TroyKomodo deleted the minor-updates branch June 29, 2020 17:21
@J0eppp J0eppp mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonHoffman CarsonHoffman CarsonHoffman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TroyKomodo @CarsonHoffman