Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-i build flag can cause permissions issues for go installations owned by root #50

Closed
lukasbob opened this issue Nov 20, 2020 · 2 comments · Fixed by #51
Closed

-i build flag can cause permissions issues for go installations owned by root #50

lukasbob opened this issue Nov 20, 2020 · 2 comments · Fixed by #51

Comments

@lukasbob
Copy link

Various issues suggest that using the -i build flag is no longer necessary - e.g. golang/go#37962 (comment). Further, there is a pending issue that will deprecate the flag in go1.16, removing it in 1.17: golang/go#41696.

Would it be possible to remove that build flag to make the out-of-the-box experience with bingo get smoother?

For now I have worked around the issue with chown -R <user> /usr/local/go (or wherever the installation lives).

https://github.com/bwplotka/bingo/blob/master/pkg/runner/runner.go#L212
@bwplotka
Copy link
Owner

Thanks for tip! Yes let's rethink this then, we have to remove -i seems like (:

bwplotka added a commit that referenced this issue Nov 20, 2020
@bwplotka
Removed -i option from build, which was unnecesary and will be deprec…
510d479 
…ated.

Fixes #50

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka
Copy link
Owner

Done (:

@bwplotka bwplotka mentioned this issue Nov 20, 2020
Merged
bwplotka added a commit that referenced this issue Nov 20, 2020
@bwplotka
Removed -i option from build, which was unnecesary and will be deprec…
f6ebd25 
…ated. (#51)

Fixes #50

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed -i option from build, which was unnecesary and will be deprecated. bwplotka/bingo
2 participants
@lukasbob @bwplotka