-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cores/epoxy/Print.cpp: Change println() to print just \n instead of \r\n
- Loading branch information
Showing
2 changed files
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
432e304
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Brian, thanks for an awesome library! Your release notes make it clear that this is a breaking change, so no surprise here. But it's pretty unfortunate because it makes the behavior of the library explicitly different from the Arduino core (https://github.com/arduino/ArduinoCore-avr/blob/master/cores/arduino/Print.cpp#L126). I'm not completely clear what you were trying to address, but I'm wondering if it would be better to modify StdioSerial to achieve the desired behavior on the output side?
Is the issue possibly related to the peculiarities of the serial monitor in the Arduino IDE? If you can provide a bit more background on what are trying to address I will try to propose an alternate PR.
Many Thanks!!!