Fix/header and method signature #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header function of PHP have only an argument to define the header name and value. This argument need to be a string. More info: https://www.php.net/header Signed-off-by: Vitor Mattos <vitor@php.rio>
Removed to test go more fast. Is very strange to have a sleep here and removing the tests worked fine. Signed-off-by: Vitor Mattos <vitor@php.rio>
The method getBody can't return null. The return of this method need to be a instance of StreamInterface. To fix this I create a instance of a class that extends StreamInterface. Reference: https://github.com/php-fig/http-message/blob/1.0/src/MessageInterface.php#L169-L171 Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
fix/header-and-method-signature
branch
from
da48cfd
to
96f2c1f
Compare
|
Thank you @vitormattos . I merged the PR with one change. The Other than that, welcome for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Usage of header function
The header function of PHP have only an argument to define the header name and value. This argument need to be a string.
More info: https://www.php.net/header
chore: remove sleep
Removed to test go more fast. Is very strange to have a sleep here and removing the tests worked fine.
fix: type of return
The method getBody can't return null. The return of this method need to be a instance of StreamInterface. To fix this I create a instance of a class that extends StreamInterface.
Reference: https://github.com/php-fig/http-message/blob/1.0/src/MessageInterface.php#L169-L171