Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance for MkDocs 1.5.0 #31

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

kamilkrzyskow
Copy link
Contributor

Hi 👋,
MkDocs 1.5.0 adds the theme.custom_dir property for ease of access and deprecates the previous theme._vars and config.user_configs. I updated the script to handle both cases via a simple API check, the assumption currently is that the theme.custom_dir won't be going away so I felt this is a cleaner approach that comparing the mkdocs.__version__.

Also tests will need to be adjusted, since they now rely on the source not changing... the themes change 1.5.0, which in turn will break every test case, because they rely on hashes... 😑I now see that hashes weren't such a good idea, I will try to handle it somehow in the coming days, since I take partial blame in the test design.

If this PR won't be merged before 1.5.0 then the world won't end, people will just have to live with the Deprecation warning for some time.

@kamilkrzyskow kamilkrzyskow marked this pull request as draft July 26, 2023 01:51
@wilhelmer wilhelmer marked this pull request as ready for review August 1, 2023 10:28
@wilhelmer wilhelmer merged commit 58835f7 into byrnereese:master Aug 1, 2023
5 checks passed
@wilhelmer
Copy link
Collaborator

So this removes the user_configs is never used in MkDocs and will be removed soon deprecation warning when building with MkDocs >1.5. Nice, thanks!

As the warning doesn't indicate which plugin causes this, we should release this to avoid confusion.

@byrnereese Please publish version 0.7.1 on PyPI. Thanks!

@kamilkrzyskow
Copy link
Contributor Author

Yeah, sorry that I'm taking so long with the simple test refactor, I just can't decide on the best path forward and therefore procrastinate.

I see that the tests passed on GitHub Actions because they don't use the newest MkDocs version, so the test methodology update isn't that urgent.

Thanks for the merge

@byrnereese
Copy link
Owner

@kamilkrzyskow 0.7.1 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants