doc: code improvement TODO based on #311

bytebeamio · Dec 10, 2023 · edbd036 · edbd036
1 parent 11aabde
commit edbd036
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/uplink/src/base/serializer/mod.rs b/uplink/src/base/serializer/mod.rs
@@ -555,6 +555,8 @@ impl<C: MqttClient> Serializer<C> {
                     // indefinitely write to disk to not loose data.
                     let client = match o {
                         Ok(c) => c,
+                        // TODO: while we have to transition into crash mode, it's better not to write any inflight packets onto disk.
+                        // This can be achieved with the serializer shutdown mode introduced in bytebeamio/uplink#311
                         Err(MqttError::Send(Request::Publish(publish))) => break Ok(Status::EventLoopCrash(publish, last_publish_stream)),
                         Err(e) => unreachable!("Unexpected error: {}", e),
                     };