Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spawn generators to remove time skew #272

Merged
merged 4 commits into from
Aug 22, 2023
Merged

fix: spawn generators to remove time skew #272

merged 4 commits into from
Aug 22, 2023

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 20, 2023

Closes #

Changes

Why?

Readability and timely generation of messages is a problem as we are unnecessarily relying on hand written code to handle it when tokio has abstractions that can easily improve readability as well as effectively remove the time skew

Trials Performed

Test against stage: uplink.log

As can be noted from the logs, delta between timestamp values are exactly the values expected:

# GPS
>>> 1692540495482 - 1692540494482 
1000
# BMS
>>> 1692540494732 - 1692540494482
250
# IMU
>>> 1692540494582 - 1692540494482
100
# Motor
>>> 1692540494732 - 1692540494482
250

@de-sh de-sh requested a review from tekjar August 21, 2023 13:10
@de-sh de-sh merged commit 67dff9f into main Aug 22, 2023
@de-sh de-sh deleted the fix-sim branch August 22, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant