feat: preferential ordering of streams during read from disk #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Q: Should |
tekjar
reviewed
Oct 13, 2023
uplink/src/base/bridge/stream.rs
Outdated
| @@ -75,7 +75,7 @@ where | |||
| config: &StreamConfig, | |||
| tx: Sender<Box<dyn Package>>, | |||
| ) -> Stream<T> { | |||
| let mut stream = Stream::new(name, &config.topic, config.buf_size, tx, config.compression); | |||
| let mut stream = Stream::new(name, config.clone(), config.buf_size, tx, config.compression); | |||
There was a problem hiding this comment.
Already passing config. Can we derive buf_size and compression internally?
de-sh
force-pushed
the
preferential-ordering
branch
from
7cd7920 to
6a80601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
Why?
Certain streams are more important and should be pushed to platform earlier than others, by giving users a means to configure the ordering of streams in a deterministic way, with weights, will allow us to guarantee that the important data will be sent to the data warehouse earlier than the not so important data and be available for them to consume on the platform ASAP.
Trials Performed
configure uplink instance as follows, setup without network and resume network:
Observed order of data read is deterministic: