Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: action cancellation state loss #351

Merged
merged 5 commits into from
Jun 19, 2024
Merged

fix: action cancellation state loss #351

merged 5 commits into from
Jun 19, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jun 19, 2024

Closes #

Changes

  1. Marks cancellations as successful when action is failed, else marks it as successful
  2. Adds tests for cancellation scenarios

Why?

Trials Performed

NOTE: cancellation will be marked as successful even if action was failed by any other causes other than cancellation

@de-sh de-sh requested a review from amokfa June 19, 2024 13:15
@de-sh de-sh merged commit 7849edc into main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amokfa amokfa Awaiting requested review from amokfa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@de-sh