Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow configuring max_stream_count #358

Merged
merged 5 commits into from
Aug 28, 2024
Merged

fix: allow configuring max_stream_count #358

merged 5 commits into from
Aug 28, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Aug 28, 2024

Closes #

Changes

Streams limit is made configurable
NOTE: Pre-allocates size of stream map

Why?

Trials Performed

  1. Ran uplink as usual with a max_stream_count unconfigured with 21 streams(including system stats streams), failed to accept 21st stream with:
�[31mFailed to create "t12" stream. More than max 20 streams�[0m
  1. Ran uplink with max_stream_count configured to 40 with upto 30 data streams, no issues observed
  2. Ran uplink with max_stream_count configured to 40 with upto 41 data streams:
�[31mFailed to create "t42" stream. More than max 40 streams�[0m

@de-sh de-sh requested a review from tekjar August 28, 2024 09:19
@de-sh de-sh merged commit 0faacae into main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant