On Android, use an explicit version check to detect openat2.
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android, seccomp is configured to kill processes that execute unsupported system calls, rather than returning `ENOSYS`, which breaks the auto-detection code. So on Android, use an explicit version check, using `uname`, to test whether the running kernel supports `openat2`, before trying to call it.
sunfishcode
force-pushed
the
sunfishcode/android-detect-openat2
branch
from
bee97d2
to
d64564f
Compare
|
Works! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, seccomp is configured to kill processes that execute
unsupported system calls, rather than returning
ENOSYS, whichbreaks the auto-detection code. So on Android, use an explicit
version check, using
uname, to test whether the running kernelsupports
openat2, before trying to call it.