Avoid calling openat2 on Android in more places.
#316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the `openat2` code entirely on Android with a `cfg`, and adjust other code to avoid calling it. This fixes some `openat2` calls that remained after #312.
eddyb
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Tested by:
- removing my local workaround
- outcome: app crashes with the syscall SECCOMP violation (as expected)
- switching to this PR using:
[patch.crates-io] cap-primitives = { git = "https://github.com/bytecodealliance/cap-std", branch = "sunfishcode/android-openat2" }
- outcome: app works again!
|
Thanks! |
|
This is now released in cap-std et al 1.0.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the
openat2code entirely on Android with acfg, and adjust other code to avoid calling it.This fixes some
openat2calls that remained after #312.