Fix handling of .. paths in symlinks.
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `..` appears at the end of a symlink target, but is not at the end of the full path target, don't mark the path as being expected to open a directory. This fixes the reduced testcase in bytecodealliance/wasmtime#9272.
sunfishcode
force-pushed
the
sunfishcode/dotdot-in-symlink
branch
from
6e18070
to
561f49e
Compare
sunfishcode
force-pushed
the
sunfishcode/dotdot-in-symlink
branch
from
8eb11c6
to
beac3ca
Compare
sunfishcode
added a commit
to sunfishcode/wasmtime
that referenced
this pull request
Sep 24, 2024
cap-std 3.3.0 contains bytecodealliance/cap-std#366, which fixes bytecodealliance#9272, which is about the handling of `..` in symlink destinations.
github-merge-queue bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Sep 25, 2024
* Update to cap-std 3.3.0. cap-std 3.3.0 contains bytecodealliance/cap-std#366, which fixes #9272, which is about the handling of `..` in symlink destinations. * Add wildcard vet of pulley --------- Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
..appears at the end of a symlink target, but is not at the end of the full path target, don't mark the path as being expected to open a directory.This fixes the reduced testcase in bytecodealliance/wasmtime#9272.